Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency suzuki-shunsuke/ghalint to v0.2.12 #657

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 26, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
suzuki-shunsuke/ghalint patch v0.2.11 -> v0.2.12

Release Notes

suzuki-shunsuke/ghalint (suzuki-shunsuke/ghalint)

v0.2.12

Compare Source

Pull Requests | Issues | suzuki-shunsuke/ghalint@v0.2.11...v0.2.12

Features

#​488 Add a policy job_timeout_minutes_is_required

https://github.com/suzuki-shunsuke/ghalint/blob/main/docs/policies/012.md

All jobs should set timeout-minutes.

Examples

jobs:
  foo: # The job doesn't have `timeout-minutes`
    runs-on: ubuntu-latest
    steps:
      - run: echo hello

jobs:
  foo:
    runs-on: ubuntu-latest
    timeout-minutes: 30
    steps:
      - run: echo hello
Why?

https://exercism.org/docs/building/github/gha-best-practices#h-set-timeouts-for-workflows

By default, GitHub Actions kills workflows after 6 hours if they have not finished by then. Many workflows don't need nearly as much time to finish, but sometimes unexpected errors occur or a job hangs until the workflow run is killed 6 hours after starting it. Therefore it's recommended to specify a shorter timeout.

The ideal timeout depends on the individual workflow but 30 minutes is typically more than enough for the workflows used in Exercism repos.

This has the following advantages:

PRs won't be pending CI for half the day, issues can be caught early or workflow runs can be restarted.
The number of overall parallel builds is limited, hanging jobs will not cause issues for other PRs if they are cancelled early.

Exceptions
  1. All steps set timeout-minutes
jobs:
  foo: # The job is missing `timeout-minutes`, but it's okay because all steps set timeout-minutes
    runs-on: ubuntu-latest
    steps:
      - run: echo hello
        timeout-minutes: 5
      - run: echo bar
        timeout-minutes: 5
  1. A job uses a reusable workflow

When a reusable workflow is called with uses, timeout-minutes is not available.

jobs:
  foo:
    uses: suzuki-shunsuke/renovate-config-validator-workflow/.github/workflows/validate.yaml@v0.2.3

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot enabled auto-merge (squash) June 26, 2024 13:59
@renovate renovate bot merged commit 18a7686 into main Jun 26, 2024
12 checks passed
@renovate renovate bot deleted the renovate/suzuki-shunsuke-ghalint-0.x branch June 26, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants