Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update command panic #2458

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Fix update command panic #2458

merged 5 commits into from
Nov 14, 2023

Conversation

dreamjz
Copy link
Contributor

@dreamjz dreamjz commented Nov 13, 2023 •
edited
Loading

Solve issue metioned in discuss #2457

$ aqua up gh     
FATA[0000] aqua failed         aqua_version= env=linux/amd64 error="command not managed by aqua" program=aqua
exit status 1

@suzuki-shunsuke suzuki-shunsuke added the bug Something isn't working label Nov 13, 2023
@suzuki-shunsuke suzuki-shunsuke added this to the v2.17.2 milestone Nov 13, 2023
@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

suzuki-shunsuke
suzuki-shunsuke requested changes Nov 13, 2023
View reviewed changes
pkg/controller/update/update.go Outdated Show resolved Hide resolved
pkg/controller/update/update.go Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@suzuki-shunsuke suzuki-shunsuke self-requested a review November 14, 2023 06:10
@suzuki-shunsuke
Copy link
Member

Thank you!

@suzuki-shunsuke suzuki-shunsuke merged commit 4ed4880 into aquaproj:main Nov 14, 2023
10 checks passed
@dreamjz dreamjz deleted the fix-update_command-panic branch November 14, 2023 08:07
@suzuki-shunsuke
Copy link
Member

v2.17.2 is out 🎉
https://github.com/aquaproj/aqua/releases/tag/v2.17.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzuki-shunsuke suzuki-shunsuke suzuki-shunsuke approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.17.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dreamjz @suzuki-shunsuke