Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remediation instructions should be permalinks #35

Closed
rgreinho opened this issue Jun 27, 2022 · 3 comments · Fixed by aquasecurity/avd-generator#57 or #50
Closed

Remediation instructions should be permalinks #35

rgreinho opened this issue Jun 27, 2022 · 3 comments · Fixed by aquasecurity/avd-generator#57 or #50

Comments

@rgreinho
Copy link
Contributor

On the aquasec website listing the issues and their remediation, it is currently not possible to give a link pointing to the exact subsection.

For example, it is only possible to link the "Code Changes" (https://avd.aquasec.com/compliance/softwaresupplychain/cis-1.0/cis-1.0-sourcecode/1.1) page, but not to point directly to the "1.1.3 Ensure any change to code receives approval of two strongly authenticated users" item.

Then this permalink should be used in the "Url" value of the report file generated by chain-bench.

@morwn
Copy link
Collaborator

morwn commented Jun 28, 2022

Could you please elaborate on the scenario you are trying to achieve?
AVD standard is ta page per sub-control(X.x), in addition, you have the same information within the generated report.

@rgreinho
Copy link
Contributor Author

Absolutely! My point is that the URL which is provided with a result should point to the exact remediation sub-section instead of the section page itself.

A solution would be to add an anchor at the end of the link. As a result, https://avd.aquasec.com/compliance/softwaresupplychain/cis-1.0/cis-1.0-sourcecode/1.1 would become https://avd.aquasec.com/compliance/softwaresupplychain/cis-1.0/cis-1.0-sourcecode/1.1#ensure-linear-history-is-required and the user would land exactly where it should instead of arriving at the top of the page.

@naortalmor1
Copy link
Collaborator

@morwn Please take it with @owenrumney and see how we can extend AVD to include specific link target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants