Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add permalinks for checks URL #50

Merged
merged 4 commits into from
Jul 6, 2022
Merged

add permalinks for checks URL #50

merged 4 commits into from
Jul 6, 2022

Conversation

morwn
Copy link
Collaborator

@morwn morwn commented Jul 5, 2022

Description

Currently, the JSON output contains for every check, a URL field that points to the sub-control in AVD.
This enhancement points every check to the specific checks in AVD by permalink.
for example:
Screen Shot 2022-07-05 at 16 17 27

Thanks @owenrumney for your contribution on AVD-generator side

Related issues

Checklist

@morwn morwn requested a review from naortalmor1 July 5, 2022 13:18
@morwn morwn added the enhancement New feature or request label Jul 5, 2022
@morwn morwn self-assigned this Jul 5, 2022
@morwn morwn requested a review from MorAlon1 July 5, 2022 15:36
morwn and others added 2 commits July 6, 2022 11:08
Co-authored-by: Naor Talmor <74590681+naortalmor1@users.noreply.github.com>
@morwn morwn merged commit 9fe652b into main Jul 6, 2022
@morwn morwn deleted the morwn/permalink_for_checks branch July 6, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remediation instructions should be permalinks
2 participants