Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent JSON #42

Merged
merged 4 commits into from
Jul 4, 2022
Merged

Indent JSON #42

merged 4 commits into from
Jul 4, 2022

Conversation

rgreinho
Copy link
Contributor

@rgreinho rgreinho commented Jul 1, 2022

Updates the helper function serializing the data to automatically indent
the file with 2 spaces.

Updates the helper function serializing the data to automatically indent
the file with 2 spaces.
@rgreinho
Copy link
Contributor Author

rgreinho commented Jul 1, 2022

Before:

[
{
"ID": "1.1.3",
"Name": "Ensure any change to code receives approval of two strongly authenticated users",
"Descrition": "Ensure that every code change is reviewed and approved by two authorized contributors who are strongly authenticated.",
"Remediation": "An organization can protect specific code branches — for example, the \"main\" branch which often is the version deployed to production — by setting protection rules. These rules secure your code repository from unwanted or unauthorized changes. You may set requirements for any code change to that branch, and thus specify a minimum number of reviewers required to approve a change.",
"Result": "Failed",
"Reason": "",
"Url": "https://avd.aquasec.com/compliance/softwaresupplychain/cis-1.0/cis-1.0-sourcecode/1.1"
}
]

After:

[
  {
    "ID": "1.1.3",
    "Name": "Ensure any change to code receives approval of two strongly authenticated users",
    "Descrition": "Ensure that every code change is reviewed and approved by two authorized contributors who are strongly authenticated.",
    "Remediation": "An organization can protect specific code branches — for example, the \"main\" branch which often is the version deployed to production — by setting protection rules. These rules secure your code repository from unwanted or unauthorized changes. You may set requirements for any code change to that branch, and thus specify a minimum number of reviewers required to approve a change.",
    "Result": "Failed",
    "Reason": "",
    "Url": "https://avd.aquasec.com/compliance/softwaresupplychain/cis-1.0/cis-1.0-sourcecode/1.1"
  }
]

@rgreinho
Copy link
Contributor Author

rgreinho commented Jul 1, 2022

Side comment, while re-reading the issue, I saw a typo in the struct: "Descrition" -> "Description".

Ref: https://github.com/aquasecurity/chain-bench/blob/main/internal/printer/helpers.go#L25=

naortalmor1
naortalmor1 previously approved these changes Jul 3, 2022
@naortalmor1
Copy link
Collaborator

Hi, @rgreinho please make sure you branch is updated and then we'll merge🙏🏽

@naortalmor1 naortalmor1 merged commit 67403c8 into aquasecurity:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants