Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

fix(aws): use correct signing region #1411

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix(aws): use correct signing region #1411

merged 1 commit into from
Aug 9, 2023

Conversation

nikpivkin
Copy link
Collaborator

@nikpivkin nikpivkin marked this pull request as ready for review August 2, 2023 08:42
@nikpivkin nikpivkin requested a review from simar7 as a code owner August 2, 2023 08:42
@nikpivkin
Copy link
Collaborator Author

@simar7 Test_FileScanExampleWithResultFunction test fail only on Windwos. Is the test fluky?

@nikpivkin nikpivkin marked this pull request as draft August 2, 2023 08:59
@simar7
Copy link
Member

simar7 commented Aug 2, 2023

@simar7 Test_FileScanExampleWithResultFunction test fail only on Windwos. Is the test fluky?

Hmm not sure. Are you about to spin up a Windows VM to try it out?

I can try to spin one up as well to see what's going on.

@nikpivkin
Copy link
Collaborator Author

@simar7 I have a windows pc, I'll try

@nikpivkin
Copy link
Collaborator Author

@simar7 The same test fell in another PR

@nikpivkin
Copy link
Collaborator Author

@simar7 I'm waiting for this PR to be merged

@simar7
Copy link
Member

simar7 commented Aug 5, 2023

@simar7 I'm waiting for this PR to be merged

Merged

@nikpivkin nikpivkin marked this pull request as ready for review August 6, 2023 11:38
@nikpivkin
Copy link
Collaborator Author

@simar7 Can you restart tests?

@simar7 simar7 force-pushed the fix/signing-region branch from 588c859 to aa06aed Compare August 7, 2023 20:59
@simar7 simar7 force-pushed the fix/signing-region branch from 24e1c94 to b41ba55 Compare August 8, 2023 03:57
@simar7 simar7 enabled auto-merge August 8, 2023 03:58
@knqyf263
Copy link
Contributor

knqyf263 commented Aug 8, 2023 •
edited
Loading

@simar7 You enabled auto-merge, but you didn't approve it. Is it a mistake or intended? I'd include this fix in v0.44.1.

@simar7 simar7 added this pull request to the merge queue Aug 9, 2023
@simar7
Copy link
Member

simar7 commented Aug 9, 2023

@simar7 You enabled auto-merge, but you didn't approve it. Is it a mistake or intended? I'd include this fix in v0.44.1.

Not entirely sure what happened there. I had approved the changes but my approval seems to be missing from GitHub. I've reapproved again. Once it goes through, I will cut a new defsec patch release.

Merged via the queue into aquasecurity:master with commit a89cc84 Aug 9, 2023
This was referenced Aug 9, 2023
Merged
Closed
@nikpivkin nikpivkin deleted the fix/signing-region branch August 15, 2023 04:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikpivkin @simar7 @knqyf263