-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update job-master.yaml for K8s 1.24.x labels/tolerations (#1250) #1251
Conversation
Thanks for your contribution! Add a comment for backward compatibility. |
Added backwards compatibility suggestion and was able to verify it working on K8s 1.24.x. Thanks! |
@ddubson could you please fix the errors from yaml linter ( https://github.com/aquasecurity/kube-bench/runs/7928063577?check_suite_focus=true )? Thanks. |
Should be good now. I'll fix up if any other issues pop up. |
@ddubson Thanks for fixing it. We still need to add more indentations, would you help to improve it? Thanks! https://github.com/aquasecurity/kube-bench/runs/7935294449?check_suite_focus=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution!
This is an attempt to fix issue described in #1250 -- however I'm not 100% on the approach, I would assume that you want backwards compatibility for K8s 1.23.x and below. Please advise about approach and I can make relevant amendments.