Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update job-master.yaml for K8s 1.24.x labels/tolerations (#1250) #1251

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Conversation

ddubson
Copy link
Contributor

@ddubson ddubson commented Aug 19, 2022

This is an attempt to fix issue described in #1250 -- however I'm not 100% on the approach, I would assume that you want backwards compatibility for K8s 1.23.x and below. Please advise about approach and I can make relevant amendments.

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2022

CLA assistant check
All committers have signed the CLA.

job-master.yaml Outdated Show resolved Hide resolved
@mozillazg
Copy link
Collaborator

Thanks for your contribution! Add a comment for backward compatibility.

@ddubson
Copy link
Contributor Author

ddubson commented Aug 19, 2022

Thanks for your contribution! Add a comment for backward compatibility.

Added backwards compatibility suggestion and was able to verify it working on K8s 1.24.x. Thanks!

@ddubson ddubson requested a review from mozillazg August 19, 2022 18:51
@mozillazg
Copy link
Collaborator

@ddubson could you please fix the errors from yaml linter ( https://github.com/aquasecurity/kube-bench/runs/7928063577?check_suite_focus=true )? Thanks.

@ddubson
Copy link
Contributor Author

ddubson commented Aug 20, 2022

@ddubson could you please fix the errors from yaml linter ( https://github.com/aquasecurity/kube-bench/runs/7928063577?check_suite_focus=true )? Thanks.

Should be good now. I'll fix up if any other issues pop up.

@mozillazg
Copy link
Collaborator

Should be good now. I'll fix up if any other issues pop up.

@ddubson Thanks for fixing it. We still need to add more indentations, would you help to improve it? Thanks!

https://github.com/aquasecurity/kube-bench/runs/7935294449?check_suite_focus=true

job-master.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants