0.6.1 fixes #123
Merged
0.6.1 fixes #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2022
yanivagman
reviewed
Jan 26, 2022
This was
linked to
issues
Jan 26, 2022
Fix: #34 Since libbpf commit 749b394 ("libbpf: Introduce legacy kprobe events support"), and subsequent fixes and refactorings to this code, there is no longer a need for libbpfgo to keep its own legacy kprobes code, as libbpfgo is now at libbpf v0.6.1 and that logic was added since v0.6.0.
Fix: #121 This commit forces libbpfgo.go C embedded source code function init_perf_buf to use the new perf_buffer__new() API. This is needed to make sure libbpf doesn't choose to execute compatible perf_buffer__new() function prototype, causing execution issues (seg faults) in some environments.
yanivagman
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit d259d81
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Tue Jan 25 16:36:22 2022
commit 1a666df
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Tue Jan 25 12:14:30 2022