Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selftest with deprecated api #134

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Fix selftest with deprecated api #134

merged 2 commits into from
Mar 2, 2022

Conversation

grantseltzer
Copy link
Contributor

@grantseltzer grantseltzer commented Mar 1, 2022 •
edited
Loading

Currently with libbpf v0.7 we get the following warning:

main.c:249:7: warning: 'perf_buffer__new_deprecated' is deprecated: libbpf v0.7+: use new variant of perf_buffer__new() instead [-Wdeprecated-declarations]
        pb = perf_buffer__new(bpf_map__fd(main->maps.events), 16 /* BUFFER PAGES */, &pb_opts);

This PR fixes this, which allows the selftest to pass.

@grantseltzer
Fix tcpconnect selftest to use new API and local libbpfgo
b0785e9 
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
@grantseltzer
remove unused file
c8969d5 
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
@grantseltzer grantseltzer mentioned this pull request Mar 1, 2022
Merged
rafaeldtinoco
rafaeldtinoco approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grantseltzer grantseltzer merged commit e267c80 into aquasecurity:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeldtinoco rafaeldtinoco rafaeldtinoco approved these changes

@yanivagman yanivagman Awaiting requested review from yanivagman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grantseltzer @rafaeldtinoco