Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AttachNetns to wrap bpf_program__attach_netns #205

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Add AttachNetns to wrap bpf_program__attach_netns #205

merged 3 commits into from
Aug 10, 2022

Conversation

mozillazg
Copy link
Contributor

#91

@mozillazg
Add AttachNetns to wrap bpf_program__attach_netns
501a952 
Signed-off-by: mozillazg <mozillazg101@gmail.com>
@geyslan
Copy link
Member

geyslan commented Aug 9, 2022

This PR is following the same approach of #196. Since both bpf_program__attach_netns() and bpf_program__attach_cgroup() are calling bpf_program__attach_fd() just setting a specific target_name, this LGTM so far.

@geyslan
Copy link
Member

geyslan commented Aug 9, 2022

@mozillazg could you provide a selftest to this? Thanks.

geyslan
geyslan reviewed Aug 9, 2022
View reviewed changes
libbpfgo.go Outdated Show resolved Hide resolved
mozillazg and others added 2 commits August 10, 2022 08:33
@mozillazg @geyslan
skip index 0 of networkNamespacePath
561a3ff 
Co-authored-by: G Gregório <geyslan@gmail.com>
@mozillazg
add selftest for AttachNetns
ab5d26f 
Signed-off-by: mozillazg <mozillazg101@gmail.com>
@mozillazg
Copy link
Contributor Author

@mozillazg could you provide a selftest to this? Thanks.

@geyslan Done.

image

@mozillazg mozillazg marked this pull request as ready for review August 10, 2022 01:13
@rafaeldtinoco rafaeldtinoco self-requested a review August 10, 2022 06:23
rafaeldtinoco
rafaeldtinoco approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@rafaeldtinoco rafaeldtinoco merged commit c39022f into aquasecurity:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geyslan geyslan geyslan left review comments

@rafaeldtinoco rafaeldtinoco rafaeldtinoco approved these changes

@grantseltzer grantseltzer Awaiting requested review from grantseltzer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mozillazg @geyslan @rafaeldtinoco