Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move embedded C code to a header file #257

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Move embedded C code to a header file #257

merged 3 commits into from
Oct 7, 2022

Conversation

mozillazg
Copy link
Contributor

@mozillazg mozillazg commented Oct 5, 2022 •
edited
Loading

closes #250

@mozillazg mozillazg marked this pull request as ready for review October 6, 2022 08:58
@grantseltzer
Copy link
Contributor

Thanks for this! Can you run clang-format -i ./libbpfgo.h to format the header as well? We need to redo our makefiles but for now can you also add a target for doing so?

@mozillazg
Copy link
Contributor Author

Can you run clang-format -i ./libbpfgo.h to format the header as well? We need to redo our makefiles but for now can you also add a target for doing so?

@grantseltzer done.

@grantseltzer
Copy link
Contributor

Looks good! Thank you so much @mozillazg !

@grantseltzer grantseltzer merged commit 3c30919 into aquasecurity:main Oct 7, 2022
@geyslan geyslan mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantseltzer grantseltzer grantseltzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move embedded C code to a header file
2 participants
@mozillazg @grantseltzer