Add BPFLink.Destroy #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently no way to remove a BPF probe link with this library so this patch adds support for the `bpf_link__destroy` function.
grantseltzer
approved these changes
Sep 3, 2021
geyslan
added a commit
to geyslan/kubearmor-libbpf
that referenced
this pull request
Sep 28, 2021
Detach was introduced as a temporary empty method. After discussions aquasecurity/libbpfgo#74 aquasecurity/libbpfgo#78 it was understood that it isn't feasible to use Detach() directly. In the meantime, Destroy() was implemented by a third contributor. aquasecurity/libbpfgo#69 This get rids of the previous empty function making room for the Destroy() wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way to remove a BPF probe link with this library
so this patch adds support for the
bpf_link__destroyfunction.