fix(config): Fix minimum_severity in yaml config files (#1664)

Signed-off-by: Liam Galvin <liam.galvin@aquasec.com>
aquasecurity · Apr 7, 2022 · 5b40399 · 5b40399
1 parent 16a1923
commit 5b40399
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/internal/pkg/config/config.go b/internal/pkg/config/config.go
@@ -13,7 +13,7 @@ import (
 )
 
 type Config struct {
-	MinimumSeverity        string            `json:"minimum_severity,omitempty"`
+	MinimumSeverity        string            `json:"minimum_severity,omitempty" yaml:"minimum_severity,omitempty"`
 	SeverityOverrides      map[string]string `json:"severity_overrides,omitempty" yaml:"severity_overrides,omitempty"`
 	ExcludedChecks         []string          `json:"exclude,omitempty" yaml:"exclude,omitempty"`
 	IncludedChecks         []string          `json:"include,omitempty" yaml:"include,omitempty"`

diff --git a/test/flags_test.go b/test/flags_test.go
@@ -417,6 +417,17 @@ func Test_Flag_MinimumSeverity(t *testing.T) {
 	assert.Less(t, len(results), len(beforeResults))
 }
 
+func Test_Flag_ConfigFile_WithMinimumSeverity(t *testing.T) {
+	before, err, _ := runWithArgs("./testdata/fail")
+	assert.Equal(t, "", err)
+	beforeResults := parseLovely(t, before)
+
+	out, err, _ := runWithArgs("./testdata/fail", "--config-file", "./testdata/config-minimum-severity/config.yml")
+	assert.Equal(t, "", err)
+	results := parseLovely(t, out)
+	assert.Less(t, len(results), len(beforeResults))
+}
+
 func Test_Flag_RegoPolicyDir(t *testing.T) {
 	out, err, exit := runWithArgs("./testdata/rego/tf", "--rego-policy-dir", "./testdata/rego/policies")
 	assert.Equal(t, "", err)

diff --git a/test/testdata/config-minimum-severity/config.yml b/test/testdata/config-minimum-severity/config.yml
@@ -0,0 +1 @@
+minimum_severity: MEDIUM