-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(extensions) probes: create probe group, events: start work #3223
(extensions) probes: create probe group, events: start work #3223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1ing and it's your call if you want to make the following changes before merging.
You had good and valid points. I did the changes and pushed, I'll consider you're still +1 as there are no other changes. Will merge if tests pass after the current bug fix release. Thanks for reviewing this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typos only @rafaeldtinoco, LGMT otherwise.
- change argument ordering for readability - keep a single creation function
Forgot to write that I want to review this before merging... |
Thanks for reviewing, no matter the timing. I'll provide a chore PR with adjustments. |
Including observations in the next PR. |
This is the initial work of the Tracee Extensions, I'm preparing the baseline for #3170 (the multiple eBPF objects), which is a needed step for #2991 (API server) and the extensions:
commit 736137d (HEAD -> extensions-probe-group, rafaeldtinoco/extensions-probe-group, myowntracee)
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Mon Jun 12 04:53:14 2023
commit ef78144
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Mon Jun 12 02:02:42 2023
commit 7d588e9
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Mon Jun 5 19:16:49 2023