Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not use deny in rule name #283

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: do not use deny in rule name #283

merged 1 commit into from
Oct 30, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Oct 30, 2024 •
edited
Loading

Rule names must not start with deny or else they will be used as a result. https://github.com/aquasecurity/trivy/blob/main/pkg/iac/rego/scanner.go#L390

@nikpivkin
fix: do not use deny in rule name
02c3dfa 
Signed-off-by: Nikita Pivkin <nikita.pivkin@smartforce.io>
@nikpivkin nikpivkin marked this pull request as ready for review October 30, 2024 05:20
@nikpivkin nikpivkin requested a review from simar7 as a code owner October 30, 2024 05:20
@nikpivkin nikpivkin mentioned this pull request Oct 30, 2024
Merged
@simar7 simar7 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into aquasecurity:main with commit 1ec0a73 Oct 30, 2024
5 checks passed
@nikpivkin nikpivkin deleted the fix-docker-secrets branch October 30, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikpivkin @simar7