feat: setup tests for examples of checks #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpivkin
force-pushed
the
test-examples-2
branch
2 times, most recently
from
301e917 to
c6b3669
Compare
Signed-off-by: Nikita Pivkin <nikita.pivkin@smartforce.io>
nikpivkin
force-pushed
the
test-examples-2
branch
from
c6b3669 to
6f87522
Compare
nikpivkin
force-pushed
the
test-examples-2
branch
from
6f87522 to
e147fe3
Compare
simar7
reviewed
Dec 4, 2024
integration/check_examples_test.go
Outdated
| require.NoError(t, err) | ||
|
|
||
| parts := strings.Split(relPath, string(os.PathSeparator)) | ||
| require.Len(t, parts, 5) // should never happen |
There was a problem hiding this comment.
what do you mean by this comment?
There was a problem hiding this comment.
That comment is irrelevant, I've removed it
Signed-off-by: Nikita Pivkin <nikita.pivkin@smartforce.io>
nikpivkin
force-pushed
the
test-examples-2
branch
from
e147fe3 to
7546ed6
Compare
simar7
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an integration test to validate examples and test checks and fixes some examples and checks.
Related PRs:
TODO: