Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cron): pin ubuntu-24.04 runner and use installed (bump to v1.2.0) oras version #450

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Oct 15, 2024

Description

ubuntu-24.04 runner is now latest runner.

But ubuntu-24.04 runner doesn't have preinstalled oras - https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#cli-tools

Before using ubuntu-24.04 - we used ubuntu-22.04.
ubuntu-22.04 contains oras v1.2.0.

Changes of this PR:

  • pin ubuntu-24.04 runner (to avoid problem with next update latest runner).
  • bump installed oras version to v1.2.0 (as in ubuntu-22.04 runner)
  • use installed oras.

test run - https://github.com/DmitriyLewen/trivy-db/actions/runs/11339374413/job/31534396989

@DmitriyLewen DmitriyLewen self-assigned this Oct 15, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 15, 2024 05:08
@knqyf263
Copy link
Collaborator

We were not using oras locally installed accidentally, and the error started occurring as ubuntu-24.04 deleted oras from the installed tools, right?

@DmitriyLewen
Copy link
Contributor Author

DmitriyLewen commented Oct 15, 2024

We were not using oras locally installed accidentally

Right.

error started occurring as ubuntu-24.04 deleted oras from the installed tools, right?

Almost right. ubuntu-22.04 contains oras v1.2.0. But ubuntu-24.04 doesn't contain oras.
GitHub didn't remove oras. GitHub started using ubuntu-24.04 as latest.

@knqyf263
Copy link
Collaborator

knqyf263 commented Oct 15, 2024

Yes, I meant GitHub deleted oras starting from ubuntu-24.04. So, this PR title and description look like it just updates the oras version, but it actually fixes some problems. Can you update the title and the description to clarify that?

@DmitriyLewen DmitriyLewen changed the title ci(cron): bump oras from v1.0.0 to v1.2.0 fix(cron): pin ubuntu-24.04 runner and use installed (bump to v1.2.0) oras version Oct 15, 2024
@DmitriyLewen
Copy link
Contributor Author

@knqyf263 Done

@knqyf263 knqyf263 merged commit 358e1d6 into aquasecurity:main Oct 15, 2024
2 checks passed
@DmitriyLewen DmitriyLewen deleted the ci/cron-fix-oras branch October 15, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants