chore: bump defsec and trivy-policies #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
reviewed
Oct 24, 2023
Comment on lines
+27
to
+42
| // func TestRulesAgainstExampleCode(t *testing.T) { | ||
| // for _, rule := range rules.GetRegistered(framework.ALL) { | ||
| // testName := fmt.Sprintf("%s/%s", rule.GetRule().AVDID, rule.LongID()) | ||
| // t.Run(testName, func(t *testing.T) { | ||
| // rule := rule | ||
| // t.Parallel() | ||
|
|
||
| // t.Run("avd docs", func(t *testing.T) { | ||
| // provider := strings.ToLower(rule.GetRule().Provider.ConstName()) | ||
| // service := strings.ToLower(strings.ReplaceAll(rule.GetRule().Service, "-", "")) | ||
| // _, err := os.Stat(filepath.Join("..", "avd_docs", provider, service, rule.GetRule().AVDID, "docs.md")) | ||
| // require.NoError(t, err) | ||
| // }) | ||
| // }) | ||
| // } | ||
| // } |
There was a problem hiding this comment.
@simar7 To perform this test, we need to generate documentation. Should I generate it as part of this PR?
There was a problem hiding this comment.
I see - let's do it in a separate PR then otherwise it will clutter this PR.
simar7
approved these changes
Oct 24, 2023
simar7
pushed a commit
that referenced
this pull request
Oct 24, 2023
* bump defsec and trivy-policies * test: use embedded FS * refactor: use embedded FS to generate documentation * chore: bump defsec and trivy-policies * refactor: use registered rules as is
simar7
pushed a commit
that referenced
this pull request
Oct 24, 2023
* bump defsec and trivy-policies * test: use embedded FS * refactor: use embedded FS to generate documentation * chore: bump defsec and trivy-policies * refactor: use registered rules as is
simar7
added a commit
that referenced
this pull request
Oct 25, 2023
* feat(schema): Add schema generation * mv pkg/rego and pkg/rules from trivy-policies * update go mod * mv internal/rules/ pkg * update schema ids * remove trivy-policies/pkg/rego imports * fix schema json * fix cyclic dependency * fix Test_OS_FS * chore: bump defsec and trivy-policies (#33) * bump defsec and trivy-policies * test: use embedded FS * refactor: use embedded FS to generate documentation * chore: bump defsec and trivy-policies * refactor: use registered rules as is --------- Co-authored-by: Nikita Pivkin <nikita.pivkin@smartforce.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs