-
Notifications
You must be signed in to change notification settings - Fork 7
fix(gke): Remove pod-security-policy-config
check
#43
Conversation
c9ec157
to
9755a2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikpivkin could you take a look as well?
@simar7 I think we should first remove the PodSecurityPolicy field from defsec and the rule from trivy-policies to update the schema and documentation found in this repository. |
I opened PR aquasecurity/defsec#1492. @simar7 I checked, and found that the policies do not use this field when scanning GKE, so they don't need to be updated. But Pod Security Policies are checked when scanning k8s. I think we should create a separate issue for that. Wdyt? |
@chen-keinan what do you think? Should we deprecate PSP altogether as mentioned above? |
its true |
@chen-keinan trivy-iac also scans k8s |
isn't the rules above are made for terraform files ? |
@chen-keinan This policy is used when scanning k8s and helm. |
@nikpivkin so maybe I'm misunderstanding which policies you suggested to removed ? |
@chen-keinan PodSecurityPolicy was removed from Kubernetes in v1.25, but it is used in k8s policy. That's why I suggested creating a issue for it, but not removing the rule. |
I see , thanks for clarifications |
As for the separate issue, we should do that for those policies as they don't seem to use these fields (but a separate k8s rego library). |
I've created aquasecurity/trivy#5541 to track it. |
Remove the check as part of aquasecurity/trivy#5011
Related PRs