Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): support for versioned resources of k8s provider #66

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

nikpivkin
Copy link
Collaborator

Close aquasecurity/trivy#5115

The k8s provider since version 2.7.0 adds version suffixes to resources and data sources. We should ignore these suffixes.

Ref:

@nikpivkin nikpivkin changed the title feat(terraform): ignore versions for k8s resources feat(terraform): support for versioned resources of k8s provider Dec 13, 2023
"github.com/aquasecurity/defsec/pkg/providers/kubernetes"
"github.com/aquasecurity/defsec/pkg/terraform"
)

var versionRegex = regexp.MustCompile(`^v\d+(beta\d+)?$`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provider withdraws support for alpha version:

We will continue our policy of not building support for alpha versioned resources into the provider

@simar7 simar7 self-requested a review January 10, 2024 22:46
@simar7 simar7 force-pushed the k8s-versions branch 2 times, most recently from 9abd79c to 88bdc30 Compare January 11, 2024 00:58
@simar7 simar7 merged commit 72ed9e5 into aquasecurity:main Jan 11, 2024
4 checks passed
@nikpivkin nikpivkin deleted the k8s-versions branch January 11, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(terraform): support for versioned resources of kubernetes provider
2 participants