-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lint): Add support for linter in mage #2392
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8abbf18
chore(lint): Add golangci-lint target for mage
simar7 ace0067
add linter fixes
simar7 2a6c382
bump up complexity
simar7 0280d05
mage lint:fix
simar7 5e58f33
add linter to github actions
simar7 75342b1
fix common lint issues
simar7 f18443a
use aquasecurity/go-version
simar7 c8fe93c
use samber/lo
simar7 b150451
fix tests
simar7 eb70741
fix tests
simar7 f652f45
remove declaringEmptySlices lint rule
simar7 73d6d50
remove omitempty
simar7 3da2d49
fix tests
simar7 0638579
fix moar lint issues
simar7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,159 @@ | ||
| linters-settings: | ||
| depguard: | ||
| rules: | ||
| main: | ||
| list-mode: lax | ||
| deny: | ||
| # Cannot use gomodguard, which examines go.mod, as "golang.org/x/exp/slices" is not a module and doesn't appear in go.mod. | ||
| - pkg: "golang.org/x/exp/slices" | ||
| desc: "Use 'slices' instead" | ||
| - pkg: "golang.org/x/exp/maps" | ||
| desc: "Use 'maps' or 'github.com/samber/lo' instead" | ||
| dupl: | ||
| threshold: 100 | ||
| errcheck: | ||
| check-type-assertions: true | ||
| check-blank: true | ||
| gci: | ||
| sections: | ||
| - standard | ||
| - default | ||
| - prefix(github.com/aquasecurity/) | ||
| - blank | ||
| - dot | ||
| goconst: | ||
| min-len: 3 | ||
| min-occurrences: 3 | ||
| gocritic: | ||
| disabled-checks: | ||
| - appendAssign | ||
| - unnamedResult | ||
| - whyNoLint | ||
| - indexAlloc | ||
| - octalLiteral | ||
| - hugeParam | ||
| - rangeValCopy | ||
| - regexpSimplify | ||
| - sloppyReassign | ||
| - commentedOutCode | ||
| enabled-tags: | ||
| - diagnostic | ||
| - style | ||
| - performance | ||
| - experimental | ||
| - opinionated | ||
| settings: | ||
| ruleguard: | ||
| failOn: all | ||
| rules: '${configDir}/misc/lint/rules.go' | ||
| gocyclo: | ||
| min-complexity: 40 | ||
| gofmt: | ||
| simplify: false | ||
| rewrite-rules: | ||
| - pattern: 'interface{}' | ||
| replacement: 'any' | ||
| gomodguard: | ||
| blocked: | ||
| modules: | ||
| - github.com/hashicorp/go-version: | ||
| recommendations: | ||
| - github.com/aquasecurity/go-version | ||
| reason: "`aquasecurity/go-version` is designed for our use-cases" | ||
| - github.com/Masterminds/semver: | ||
| recommendations: | ||
| - github.com/aquasecurity/go-version | ||
| reason: "`aquasecurity/go-version` is designed for our use-cases" | ||
| gosec: | ||
| excludes: | ||
| - G101 | ||
| - G114 | ||
| - G115 | ||
| - G204 | ||
| - G304 | ||
| - G402 | ||
| govet: | ||
| check-shadowing: false | ||
| misspell: | ||
| locale: US | ||
| ignore-words: | ||
| - behaviour | ||
| - licence | ||
| - optimise | ||
| - simmilar | ||
| perfsprint: | ||
| # Optimizes even if it requires an int or uint type cast. | ||
| int-conversion: false | ||
| # Optimizes into `err.Error()` even if it is only equivalent for non-nil errors. | ||
| err-error: true | ||
| # Optimizes `fmt.Errorf`. | ||
| errorf: true | ||
| # Optimizes `fmt.Sprintf` with only one argument. | ||
| sprintf1: false | ||
| # Optimizes into strings concatenation. | ||
| strconcat: false | ||
| revive: | ||
| ignore-generated-header: true | ||
| testifylint: | ||
| enable-all: true | ||
| linters: | ||
| disable: | ||
| - structcheck # FIXME: Currently doesn't work on Go 1.18: https://github.com/golangci/golangci-lint/issues/2649 | ||
| disable-all: true | ||
| enable: | ||
| - errorlint | ||
| - bodyclose | ||
| - depguard | ||
| - gci | ||
| - goconst | ||
| - gocritic | ||
| - gocyclo | ||
| - gofmt | ||
| - gomodguard | ||
| - gosec | ||
| # - unparam FIXME: Currently doesn't work on Go 1.18: https://github.com/golangci/golangci-lint/issues/2649 | ||
| linters-settings: | ||
| gocritic: | ||
| enabled-checks: | ||
| - importShadow | ||
| - govet | ||
| - ineffassign | ||
| - misspell | ||
| - perfsprint | ||
| - revive | ||
| - tenv | ||
| - testifylint | ||
| - typecheck | ||
| - unconvert | ||
| - unused | ||
| - usestdlibvars | ||
|
|
||
| run: | ||
| timeout: 5m | ||
| go: '1.23' | ||
| timeout: 30m | ||
|
|
||
| issues: | ||
| exclude-files: | ||
| - "mock_*.go$" | ||
| - "examples/*" | ||
| exclude-dirs: | ||
| - "pkg/iac/scanners/terraform/parser/funcs" # copies of Terraform functions | ||
| exclude-rules: | ||
| - path: ".*_test.go$" | ||
| linters: | ||
| - goconst | ||
| - gosec | ||
| - unused | ||
| - path: ".*_test.go$" | ||
| linters: | ||
| - govet | ||
| text: "copylocks:" | ||
| - path: ".*_test.go$" | ||
| linters: | ||
| - gocritic | ||
| text: "commentFormatting:" | ||
| - path: ".*_test.go$" | ||
| linters: | ||
| - gocritic | ||
| text: "exitAfterDefer:" | ||
| - path: ".*_test.go$" | ||
| linters: | ||
| - gocritic | ||
| text: "importShadow:" | ||
| - linters: | ||
| - perfsprint | ||
| text: "fmt.Sprint" | ||
| exclude-use-default: false | ||
| max-same-issues: 0 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's relevant for trivy-operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, removed!