refactor: use error for no-summary + no-table format

pkg/flag/report_flags.go

@@ -239,8 +239,7 @@ func (f *ReportFlagGroup) ToOptions() (ReportOptions, error) {
 
 	// "--so-summary" option is available only with "--format table".
 	if noSummaryTable && format != types.FormatTable {
-		noSummaryTable = false
-		log.Warn(`"--no-summary-table" can be used only with "--format table".`)
+		return ReportOptions{}, xerrors.New(`"--no-summary-table" can be used only with "--format table".`)
 	}
 
 	cs, err := loadComplianceTypes(f.Compliance.Value())

pkg/flag/report_flags_test.go

@@ -38,6 +38,7 @@ func TestReportFlagGroup_ToOptions(t *testing.T) {
 		name     string
 		fields   fields
 		want     flag.ReportOptions
+		wantErr  string
 		wantLogs []string
 	}{
 		{
@@ -116,20 +117,6 @@ func TestReportFlagGroup_ToOptions(t *testing.T) {
 				ListAllPkgs: true,
 			},
 		},
-		{
-			name: "invalid option combination: --no-summary-table with --format json",
-			fields: fields{
-				format:         "json",
-				noSummaryTable: true,
-			},
-			wantLogs: []string{
-				`"--no-summary-table" can be used only with "--format table".`,
-			},
-			want: flag.ReportOptions{
-				Format:         "json",
-				NoSummaryTable: false,
-			},
-		},
 		{
 			name: "happy path with output plugin args",
 			fields: fields{
@@ -175,6 +162,14 @@ func TestReportFlagGroup_ToOptions(t *testing.T) {
 				Severities: []dbTypes.Severity{dbTypes.SeverityLow},
 			},
 		},
+		{
+			name: "invalid option combination: --no-summary-table with --format json",
+			fields: fields{
+				format:         "json",
+				noSummaryTable: true,
+			},
+			wantErr: `"--no-summary-table" can be used only with "--format table".`,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
@@ -219,7 +214,11 @@ func TestReportFlagGroup_ToOptions(t *testing.T) {
 			}
 
 			got, err := f.ToOptions()
-			require.NoError(t, err)
+			if tt.wantErr != "" {
+				require.Contains(t, err.Error(), tt.wantErr)
+				return
+			}
+
 			assert.EqualExportedValuesf(t, tt.want, got, "ToOptions()")
 
 			// Assert log messages