feat(misconf): Add glob support to --skip-dirs and --skip-files o…

…ptions

Addresses: #3754

Signed-off-by: Simar <simar@linux.com>

pkg/flag/options.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"io"
 	"os"
+	"path/filepath"
 	"strings"
 	"sync"
 	"time"
@@ -249,6 +250,24 @@ func getValue(flag *Flag) any {
 	return viper.Get(flag.ConfigName)
 }
 
+func explodeGlob(paths []string, dir string) []string {
+	var exploded []string
+
+	for _, path := range paths {
+		if !strings.Contains(path, "*") {
+			exploded = append(exploded, path)
+			continue
+		}
+		if globPaths, err := filepath.Glob(filepath.Join(dir, path)); err == nil {
+			for _, globPath := range globPaths {
+				exploded = append(exploded, globPath)
+			}
+		}
+	}
+
+	return exploded
+}
+
 func (f *Flags) groups() []FlagGroup {
 	var groups []FlagGroup
 	// This order affects the usage message, so they are sorted by frequency of use.

pkg/flag/options_test.go

@@ -1,6 +1,7 @@
 package flag
 
 import (
+	"fmt"
 	"testing"
 
 	"github.com/spf13/viper"
@@ -80,3 +81,34 @@ func Test_getStringSlice(t *testing.T) {
 		})
 	}
 }
+
+func Test_explodeGlob(t *testing.T) {
+	testCases := []struct {
+		skipInput []string
+		want      []string
+	}{
+		{
+			skipInput: []string{"./testdata/*/*"},
+			want:      []string{"testdata/.dotdir/bar", "testdata/.dotdir/foo"},
+		},
+		{
+			skipInput: []string{"./testdata/*/bar"},
+			want:      []string{"testdata/.dotdir/bar"},
+		},
+		{
+			skipInput: []string{"path/with/no/glob"},
+			want:      []string{"path/with/no/glob"},
+		},
+		{
+			skipInput: []string{"./testdata/doesnotexist/*"},
+			want:      []string(nil),
+		},
+	}
+
+	for i, tc := range testCases {
+		t.Run(fmt.Sprint(i), func(t *testing.T) {
+			assert.Equal(t, tc.want, explodeGlob(tc.skipInput, "."))
+		})
+	}
+
+}

pkg/flag/scan_flags.go

@@ -138,8 +138,8 @@ func (f *ScanFlagGroup) ToOptions(args []string) (ScanOptions, error) {
 
 	return ScanOptions{
 		Target:       target,
-		SkipDirs:     getStringSlice(f.SkipDirs),
-		SkipFiles:    getStringSlice(f.SkipFiles),
+		SkipDirs:     explodeGlob(getStringSlice(f.SkipDirs), target),
+		SkipFiles:    explodeGlob(getStringSlice(f.SkipFiles), target),
 		OfflineScan:  getBool(f.OfflineScan),
 		Scanners:     scanners,
 		FilePatterns: getStringSlice(f.FilePatterns),

pkg/flag/testdata/.dotdir/bar

@@ -0,0 +1 @@
+bar

pkg/flag/testdata/.dotdir/foo

@@ -0,0 +1 @@
+foo