Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(misconf): improve CloudFormation adapter test coverage #4885

Closed
simar7 opened this issue Mar 28, 2023 · 2 comments · Fixed by #6315
Closed

test(misconf): improve CloudFormation adapter test coverage #4885

simar7 opened this issue Mar 28, 2023 · 2 comments · Fixed by #6315
Assignees
@nikpivkin
Labels
kind/testing Categorizes issue or PR as related to a unit/integration test. scan/misconfiguration Issues relating to misconfiguration scanning
Milestone
v0.51.0

Comments

@simar7
Copy link
Member

simar7 commented Mar 28, 2023 •
edited
Loading

Currently there are no unit tests in place for CloudFormation adapters. An equivalent (e.g. ELB) in terraform can be found here: https://github.com/aquasecurity/defsec/blob/master/internal/adapters/terraform/aws/elb/adapt_test.go

This will prevent any future policies to be able to be added to defsec without having regressions and defined behaviour.
@simar7 simar7 mentioned this issue Mar 28, 2023
Merged
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@simar7 simar7 transferred this issue from aquasecurity/defsec Jul 28, 2023
@simar7 simar7 changed the title testing: improve CloudFormation adapter test coverage test(misconf): improve CloudFormation adapter test coverage Jul 28, 2023
@simar7 simar7 added kind/testing Categorizes issue or PR as related to a unit/integration test. scan/misconfiguration Issues relating to misconfiguration scanning labels Jul 28, 2023
@github-actions
Copy link

This issue is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Sep 27, 2023
@knqyf263 knqyf263 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Sep 27, 2023
@simar7 simar7 added this to the v0.50.0 milestone Mar 7, 2024
@nikpivkin nikpivkin mentioned this issue Mar 15, 2024
Merged
6 tasks
@simar7 simar7 modified the milestones: v0.50.0, v0.51.0 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikpivkin nikpivkin

Labels
kind/testing Categorizes issue or PR as related to a unit/integration test. scan/misconfiguration Issues relating to misconfiguration scanning
Projects
Trivy Roadmap
Archived in project
Milestone
v0.51.0
Development

Successfully merging a pull request may close this issue.

test(cloudformation): add CF tests nikpivkin/trivy
3 participants
@simar7 @knqyf263 @nikpivkin