Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cloudformation): add CF tests #6315

Merged
merged 1 commit into from
Mar 29, 2024
Merged

test(cloudformation): add CF tests #6315

merged 1 commit into from
Mar 29, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Mar 13, 2024 •
edited
Loading

Description

I have created TODOs for major inconsistencies, such as where the type of state parameter needs to be changed. Minor inaccuracies, such as an incorrect parameter name, I have fixed.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review March 15, 2024 09:52
@nikpivkin nikpivkin requested a review from simar7 as a code owner March 15, 2024 09:52
simar7
simar7 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through the TODOs and they made sense to me. The rest of the coverage, I test your judgement 😄

since it is not critical, we can merge it in v0.51.0

@simar7 simar7 added this pull request to the merge queue Mar 29, 2024
Merged via the queue into aquasecurity:main with commit 625f22b Mar 29, 2024
14 checks passed
@nikpivkin nikpivkin deleted the cf-adapt-tests branch March 29, 2024 04:09
fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
@nikpivkin @fl0pp5
test(cloudformation): add CF tests (aquasecurity#6315)
c9a2e1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test(misconf): improve CloudFormation adapter test coverage
2 participants
@nikpivkin @simar7