Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checks): Add support for deprecating checks #6626

Closed
simar7 opened this issue May 4, 2024 · 1 comment
Closed

feat(checks): Add support for deprecating checks #6626

simar7 opened this issue May 4, 2024 · 1 comment
Assignees
@simar7
Labels
kind/feature Categorizes issue or PR as related to a new feature. scan/misconfiguration Issues relating to misconfiguration scanning
Milestone
v0.52.0

Comments

@simar7
Copy link
Member

simar7 commented May 4, 2024

Sometimes checks are no longer relevant themselves or apply to resources that have been deprecated. For instance AWS has retired EC2-Classic networking.

In such cases, we should deprecate a check that pertains to these resources as it no longer adds any value to the user.

We still would need to keep the check around, along with its AVD ID as we still would consider that ID to be taken up by this check. This would ensure that no other check can be mistakenly confused with this retired check.

Furthermore, AVD could also add some UI elements to indicate that this check is now deprecated.
@simar7 simar7 added kind/feature Categorizes issue or PR as related to a new feature. scan/misconfiguration Issues relating to misconfiguration scanning labels May 4, 2024
@simar7 simar7 self-assigned this May 4, 2024
@simar7 simar7 mentioned this issue May 4, 2024
Merged
@simar7
Copy link
Member Author

simar7 commented May 8, 2024

Another idea we can have is a CLI option to ignore deprecated checks such as: --ignore-deprecated-checks

@simar7 simar7 added this to the v0.52.0 milestone May 8, 2024
simar7 added a commit that referenced this issue May 8, 2024
@simar7
feat(misconf): Add support for deprecating a check
9cd5294 
Implements: #6626

Signed-off-by: Simar <simar@linux.com>
This was referenced May 9, 2024
Merged
Closed
@simar7 simar7 closed this as completed May 22, 2024
@nikpivkin nikpivkin mentioned this issue Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simar7 simar7

Labels
kind/feature Categorizes issue or PR as related to a new feature. scan/misconfiguration Issues relating to misconfiguration scanning
Projects
Trivy Roadmap
Archived in project
Milestone
v0.52.0
Development

No branches or pull requests
1 participant
@simar7