Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): always output fatal errors to stderr #6827

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

knqyf263
Copy link
Collaborator

Description

--quiet currently suppresses even fatal errors.

Before

$ trivy image unknown --quiet 

After

$ trivy image unknown --quiet
2024-05-30T16:16:14+04:00        FATAL   Fatal error     image scan error: scan error: unable to initialize a scanner: unable to initialize an image scanner: unable to find the specified image "unknown" in ["docker" "containerd" "podman" "remote"]: 4 errors occurred:
        * docker error: unable to inspect the image (unknown): Error response from daemon: No such image: unknown:latest
        * containerd error: containerd socket not found: /run/containerd/containerd.sock
        * podman error: unable to initialize Podman client: no podman socket found: stat podman/podman.sock: no such file or directory
        * remote error: GET https://index.docker.io/v2/library/unknown/manifests/latest: UNAUTHORIZED: authentication required; [map[Action:pull Class: Name:library/unknown Type:repository]]

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this May 30, 2024
@chen-keinan
Copy link
Contributor

chen-keinan commented May 30, 2024

Thanks!!

Copy link
Contributor

@chen-keinan chen-keinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knqyf263 lgtm 🚀

@knqyf263 knqyf263 added this pull request to the merge queue Jun 2, 2024
Merged via the queue into aquasecurity:main with commit c2b9132 Jun 2, 2024
12 checks passed
@knqyf263 knqyf263 deleted the fix/fatal_errs branch June 2, 2024 12:03
@aqua-bot aqua-bot mentioned this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants