Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): always output fatal errors to stderr #6827

Merged
merged 1 commit into from
Jun 2, 2024
Merged

fix(cli): always output fatal errors to stderr #6827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/log/logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ func Errorf(format string, args ...any) { slog.Default().Error(fmt.Sprintf(forma

// Fatal for logging fatal errors
func Fatal(msg string, args ...any) {
slog.Default().Log(context.Background(), LevelFatal, msg, args...)
// Fatal errors should be logged to stderr even if the logger is disabled.
New(NewHandler(os.Stderr, &Options{})).Log(context.Background(), LevelFatal, msg, args...)
os.Exit(1)
}

Expand Down