Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test docs separately from code #3392

Merged
merged 1 commit into from
Jan 8, 2023
Merged

Conversation

itaysk
Copy link
Contributor

@itaysk itaysk commented Jan 5, 2023

Description

we don't need all the tests to run on every docs PR

Related issues

Related PRs

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@itaysk itaysk requested a review from knqyf263 as a code owner January 5, 2023 14:44
@knqyf263
Copy link
Collaborator

knqyf263 commented Jan 5, 2023

I just remember why we keep running all tests, even for document updates. If unit tests are not triggered, PRs cannot be merged now. Should we remove these settings?
image

@itaysk
Copy link
Contributor Author

itaysk commented Jan 5, 2023

not sure I understand. if unit tests are not triggered (for example, it's a docs PR), then the workflow isn't triggered (after this PR is merged), so it can't block the PR, can it?

@knqyf263
Copy link
Collaborator

knqyf263 commented Jan 8, 2023

If it is not triggered, it blocks PRs.

image

@knqyf263
Copy link
Collaborator

knqyf263 commented Jan 8, 2023

I've removed all other required checks other than CLA.
image

@knqyf263 knqyf263 merged commit 044fb97 into aquasecurity:main Jan 8, 2023
@itaysk itaysk deleted the docstest branch January 8, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants