-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adding a terraform tutorial to the docs #3708
Conversation
@giorod3 could you please take a look and let me know anything else that you would like to have included? |
This PR is stale because it has been labeled with inactivity. |
hi @AnaisUrlichs any update on this? |
Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>
3e15f4d
to
23900e7
Compare
@simar7 could you please have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The `trivy config` command can scan Terraform configuration, CloudFormation, Dockerfile, Kubernetes manifests, and Helm Charts for misconfiguration. Trivy will compare the configuration found in the file with a set of best practices. | ||
|
||
- If the configuration is following best practices, the check will pass, | ||
- If the configuration does not define some configuration according to best practices, the default is used, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does "the default is used" mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, if you e.g. do not set the PullPolicy
Trivy will use the default. I rewrote it:
If the configuration does not define the resource of some configuration, Trivy will assume the default configuration for the resource creation is used. In this case, the check might fail.
``` | ||
trivy conf --tf-vars terraform.tfvars ./ | ||
``` | ||
### Custom Policy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
following the new terminology, Custom checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still call them policy in the docs https://aquasecurity.github.io/trivy/v0.42/docs/scanner/misconfiguration/custom/
Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>
278f3b3
to
2d4f792
Compare
Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>
We received a lot of questions by the tfsec community on how to move over to Trivy, how different Trivy for terraform scanning is and similar.