Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flag): Add glob support to --skip-dirs and --skip-files #3866

Merged
merged 7 commits into from
Mar 30, 2023
Merged

feat(flag): Add glob support to --skip-dirs and --skip-files #3866

merged 7 commits into from
Mar 30, 2023

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Mar 18, 2023 •
edited
Loading

Addresses: #3754

Description

This adds the ability to specify globs as part of the --skip-dirs and --skip-files options.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

simar7 added 2 commits March 17, 2023 17:08
@simar7
feat(misconf): Add glob support to --skip-dirs and --skip-files o…
b400110 
…ptions

Addresses: #3754

Signed-off-by: Simar <simar@linux.com>
@simar7
update docs
39955e2
@simar7 simar7 marked this pull request as ready for review March 18, 2023 00:20
@simar7 simar7 mentioned this pull request Mar 18, 2023
Closed
knqyf263
knqyf263 reviewed Mar 20, 2023
View reviewed changes
@simar7 simar7 force-pushed the skip-dirs-support-globs branch 5 times, most recently from 7203155 to 2ec67eb Compare March 22, 2023 04:57
@simar7
filter in the walker instead
d39209f 
Signed-off-by: Simar <simar@linux.com>
@simar7 simar7 force-pushed the skip-dirs-support-globs branch from 2ec67eb to d39209f Compare March 22, 2023 05:08
simar7
simar7 commented Mar 22, 2023
View reviewed changes
simar7 added 4 commits March 22, 2023 12:33
@simar7
wip
3fce5c5 
Signed-off-by: Simar <simar@linux.com>
@simar7
fix tests
fa5c515 
Signed-off-by: Simar <simar@linux.com>
@simar7
wip
dd5e38b 
Signed-off-by: Simar <simar@linux.com>
@simar7
clean up and fix tests
f1fb1da 
Signed-off-by: Simar <simar@linux.com>
@simar7 simar7 requested a review from knqyf263 March 23, 2023 22:33
@simar7
Copy link
Member Author

simar7 commented Mar 28, 2023

Hey @knqyf263 could you take another look at it?

@knqyf263
Copy link
Collaborator

Actually, I already left a comment.
#3866 (comment)

@simar7
Copy link
Member Author

simar7 commented Mar 29, 2023

Actually, I already left a comment.
#3866 (comment)

Sorry missed that, I replied: #3866 (comment)

@knqyf263 knqyf263 merged commit abff139 into main Mar 30, 2023
@knqyf263
Copy link
Collaborator

Cool!

@knqyf263 knqyf263 deleted the skip-dirs-support-globs branch March 30, 2023 07:49
itaysk
itaysk reviewed Mar 31, 2023
View reviewed changes
Copy link
Contributor

@itaysk itaysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we support glog patterns, why do we need both skip files and dirs flags?

docs/docs/vulnerability/examples/others.md
Copy link
Contributor

@itaysk itaysk Mar 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in addition to the image target, this should work in other targets as well, right? if so docs are missing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK made a follow up PR to update that #3945

@wyardley
Copy link
Contributor

Woo, thanks!

@knqyf263 knqyf263 mentioned this pull request Apr 3, 2023
Closed
@axi92
Copy link

axi92 commented Apr 3, 2023

Nice ty!

@wyardley wyardley mentioned this pull request Jul 27, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaysk itaysk itaysk left review comments

@knqyf263 knqyf263 knqyf263 approved these changes

@AnaisUrlichs AnaisUrlichs AnaisUrlichs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@simar7 @knqyf263 @wyardley @axi92 @itaysk @AnaisUrlichs