Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip wrong update of test golden files #4379

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented May 15, 2023

Description

TestFanal_Library_DockerMode test uses image with uncompressed layers and updates golden test files without Digest.
Skip this test to avoid building incorrect golden files, when using go test -tags=integration ./pkg/fanal/test/integration/... -update command.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen marked this pull request as ready for review May 15, 2023 07:29
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner May 15, 2023 07:29
@DmitriyLewen DmitriyLewen self-assigned this May 15, 2023
@knqyf263 knqyf263 merged commit 50c8b41 into aquasecurity:main May 15, 2023
@DmitriyLewen DmitriyLewen deleted the test/dont-update-golden-if-digest-is-empty branch May 15, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants