feat(aws): Add support to see successes in results

[simar7]

Signed-off-by: Simar simar@linux.com

Description

Add the ability to show successes when evaluating AWS results

Related issues

• Close feat: Include Non Failures in AWS scan report #4426

Checklist

• I've read the guidelines for contributing to this repository.
• I've followed the conventions in the PR title.
• I've added tests that prove my fix is effective or that my feature works.
• I've updated the documentation with the relevant information (if needed).
• I've added usage information (if the PR introduces new options)
• I've included a "before" and "after" example to the description (if the PR is a user interface change).

[simar7]

Should we make this the new default for JSON output? Or should we introduce a new command line flag? --show-successes?

Based on the last call I had with Itay, I think we concluded that today Trivy shows failures for "things that are genuinely wrong/bad" and not because "they don't exist". Based on this, if we show things that PASS, they will only show up if they didn't FAIL.

Or in other words, you won't see passing results for things that were not evaluated because of any reason (not applicable, not found, etc.)

Based on the above, I lean towards a new flag.

Thoughts? @knqyf263 and @itaysk

[knqyf263]

Is it something different from --include-non-failures?

$ trivy config -h | grep success
      --include-non-failures      include successes and exceptions, available with '--scanners config'

[simar7]

Is it something different from --include-non-failures?

$ trivy config -h | grep success
      --include-non-failures      include successes and exceptions, available with '--scanners config'

Oh interesting, I didn't know about that flag. Will try it out.

[simar7]

Looks like the flag wasn't used in Cloud scanning, I've added it here. The results will still only be shown in the JSON output.

[knqyf263]

@simar7 Is this ready for review now?

[simar7]

@simar7 Is this ready for review now?

Yes, I've marked it ready for review (out of draft). Let me know how it goes and if I can answer any questions.

[knqyf263]

LGTM, but we're in the bug fix sprint now for v0.42.1. I'll merge this PR afterward.