Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbom): export empty dependencies in CycloneDX #4568

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

nikpivkin
Copy link
Contributor

Description

According to the CycloneDx documentation: Components that do not have their own dependencies MUST be declared as empty elements within the graph.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@afdesk afdesk marked this pull request as ready for review June 6, 2023 08:33
@afdesk afdesk requested a review from knqyf263 as a code owner June 6, 2023 08:33
@knqyf263 knqyf263 merged commit 17d7536 into aquasecurity:main Jun 6, 2023
@knqyf263
Copy link
Collaborator

knqyf263 commented Jun 6, 2023

Thanks, @nikpivkin and @afdesk !

@nikpivkin nikpivkin deleted the fix/cyclonedx-dependsOn-null branch June 16, 2023 09:23
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CycloneDX JSON is invalid: dependencies.dependsOn is null
2 participants