Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the test cases for iam passing role #4667

Closed
wants to merge 2 commits into from

Conversation

r-khurram
Copy link

@r-khurram r-khurram commented Jun 19, 2023

Description

Added a field DisableEmbeddedPolicies: true in the test case. So that test cases can only use the given policy.

Related issues

Related PRs

  • #XXX
  • #YYY

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@r-khurram r-khurram requested a review from knqyf263 as a code owner June 19, 2023 12:24
@CLAassistant
Copy link

CLAassistant commented Jun 19, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Phaedra Solutions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@r-khurram r-khurram changed the title Fixed the test cases for iam passing role fix: Fixed the test cases for iam passing role Jun 19, 2023
@knqyf263 knqyf263 requested a review from simar7 June 19, 2023 13:06
@simar7
Copy link
Member

simar7 commented Jun 20, 2023

lgtm but could you please sign the CLA?

@simar7 simar7 self-requested a review June 20, 2023 15:53
@simar7
Copy link
Member

simar7 commented Jun 23, 2023

@knqyf263 - I think @r-khurram has signed the CLA but the checker has got stuck. Can we merge this manually?

@knqyf263
Copy link
Collaborator

I didn't see the CLA signature. How did you get to know @r-khurram signed?

@simar7
Copy link
Member

simar7 commented Jun 27, 2023

I didn't see the CLA signature. How did you get to know @r-khurram signed?

@r-khurram claims offline that he has signed. @r-khurram can you please confirm if you have signed?

@r-khurram
Copy link
Author

I didn't see the CLA signature. How did you get to know @r-khurram signed?

@r-khurram claims offline that he has signed. @r-khurram can you please confirm if you have signed?

image @simar7 here You can see when i clicked on the CLA

@itaysk
Copy link
Contributor

itaysk commented Jun 27, 2023

the CLA bot said what the problem is

Phaedra Solutions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

auto-merge was automatically disabled June 27, 2023 07:02

Head branch was pushed to by a user without write access

@r-khurram
Copy link
Author

the CLA bot said what the problem is

Phaedra Solutions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@itaysk Thanks i have fixed that.

@simar7
Copy link
Member

simar7 commented Jun 28, 2023

Closing as I've cut #4723 that supersedes this.

@simar7 simar7 closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Investigate why AVD-AWS-0342 triggers on any input
5 participants