Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodejs): parse package.json without name or version #4687

Closed
wants to merge 2 commits into from

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Jun 21, 2023

Description

Since the name and version are optional, we should consider package.json valid without these fields.

go-dep-parser refers to this commit.

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@afdesk afdesk self-requested a review June 21, 2023 08:47
@nikpivkin nikpivkin marked this pull request as ready for review July 12, 2023 13:27
@nikpivkin
Copy link
Contributor Author

@afdesk hi, the changes are already in main, can you close this PR?

@afdesk
Copy link
Contributor

afdesk commented Jul 13, 2023

no, It seems I can't close.
@knqyf263 Could you close it?

@knqyf263 knqyf263 closed this Jul 13, 2023
@nikpivkin nikpivkin deleted the fix/pkg-json branch July 20, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only one dependency file is scanned
3 participants