Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oci): Http registry oci pull #4701

Merged
merged 1 commit into from
Jun 26, 2023
Merged

fix(oci): Http registry oci pull #4701

merged 1 commit into from
Jun 26, 2023

Conversation

alex123012
Copy link
Contributor

@alex123012 alex123012 commented Jun 23, 2023

Description

when we try to pull trivy-db from http registry in an airgapped env we are getting the error:

2023-06-23T13:52:56.086+0300    INFO    Need to update DB
2023-06-23T13:52:56.086+0300    INFO    DB Repository: registry.quay:8080/security/trivy-db
2023-06-23T13:52:56.086+0300    INFO    Downloading DB...
true
true
2023-06-23T13:52:56.426+0300    FATAL   init error: DB error: failed to download vulnerability DB: database download error: OCI repository error: 1 error occurred:
        * Get "https://registry.quay:8080/v2/": http: server gave HTTP response to HTTPS client

This pr is fixing this issue.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: alexey.makhonin <alexey.makhonin@flant.com>
@alex123012 alex123012 requested a review from knqyf263 as a code owner June 23, 2023 12:28
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@knqyf263 knqyf263 added this pull request to the merge queue Jun 26, 2023
Merged via the queue into aquasecurity:main with commit 9be0825 Jun 26, 2023
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
Signed-off-by: alexey.makhonin <alexey.makhonin@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants