Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misconf): disable the terraform plan analyzer for other scanners #4714

Merged
merged 1 commit into from
Jun 26, 2023
Merged

fix(misconf): disable the terraform plan analyzer for other scanners #4714

merged 1 commit into from
Jun 26, 2023

Conversation

knqyf263
Copy link
Collaborator

Description

The Terraform plan analyzer was not added to the list of misconfiguration analyzers in #4523. Then, it is always enabled even when misconfiguration scanning is not enabled.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Jun 26, 2023
@knqyf263 knqyf263 marked this pull request as ready for review June 26, 2023 08:20
@knqyf263 knqyf263 force-pushed the disable_terraformplan branch from 51bd3f6 to a845def Compare June 26, 2023 08:24
@knqyf263 knqyf263 requested a review from chen-keinan June 26, 2023 10:28
@chen-keinan chen-keinan mentioned this pull request Jun 26, 2023
Closed
@knqyf263 knqyf263 added this pull request to the merge queue Jun 26, 2023
Merged via the queue into aquasecurity:main with commit 0f61a84 Jun 26, 2023
@knqyf263 knqyf263 deleted the disable_terraformplan branch June 26, 2023 11:37
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
@knqyf263 @AnaisUrlichs
fix(misconf): disable the terraform plan analyzer for other scanners (a…
10cf924 
…quasecurity#4714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chen-keinan chen-keinan chen-keinan approved these changes

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knqyf263 @chen-keinan