-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): parse licenses from dist-info folder #4724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikpivkin
Left some comments.
Take a look, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
looking forward to it! @knqyf263 @DmitriyLewen any update with this one? |
This PR is stale because it has been labeled with inactivity. |
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Description
PEP-639 proposes adding the
License-File
field, which contains the path relative to the root of the project to the license-related file (but setuptools records the full relative path to the license). This PR adds support for new license-related fields. If a specific license is not specified in the metadata, then we can classify the license from the file that is specified in theLicense-File
field.Currently, the Wheel and (following its example) Setuptools projects flatten all license files into the .dist-info directory without preserving the source subdirectory hierarchy.
PEP-639 proposes several options for the location of files.
Related issues
Related PRs
Checklist