Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add 'Signature Verification' guide #4731

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

nikpivkin
Copy link
Contributor

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263
Copy link
Collaborator

@nikpivkin LGTM! Thanks 👍

@AnaisUrlichs Where do we want to add this page? NIkita added it to "getting started".

Copy link
Contributor

@AnaisUrlichs AnaisUrlichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to add that to supply-chain https://aquasecurity.github.io/trivy/v0.43/docs/supply-chain/sbom/
what do you think @knqyf263

@itaysk
Copy link
Contributor

itaysk commented Jul 2, 2023

no supply chain is about how trivy is securing the supply chain. this should be somewhere around the installation docs

@knqyf263
Copy link
Collaborator

knqyf263 commented Jul 2, 2023

It is not a functionality of Trivy. As @itaysk, it is more like installation, but I want to keep the installation page as much as simple so that people can easily start using Trivy. Should we add a new page under getting started?

@itaysk
Copy link
Contributor

itaysk commented Jul 2, 2023

If not under installation, maybe under "advanced"? we also have air-gapped setup guide there

@AnaisUrlichs
Copy link
Contributor

Oh sorry, I did not look at the PR properly -- maybe under a separate page e.g. https://aquasecurity.github.io/trivy/v0.43/trivy-signature-verification

@nikpivkin
Copy link
Contributor Author

@itaysk @AnaisUrlichs Okay, I'll wait for your decision and move the documentation to the appropriate section.

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Sep 3, 2023
@itaysk
Copy link
Contributor

itaysk commented Sep 5, 2023

sorry for the delay, under installation please

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Sep 6, 2023
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 force-pushed the docs-signature-verification branch from 9cc1806 to 25892cb Compare September 12, 2023 06:56
@knqyf263 knqyf263 marked this pull request as ready for review September 12, 2023 06:57
@knqyf263 knqyf263 self-requested a review as a code owner September 12, 2023 06:57
@knqyf263 knqyf263 added this pull request to the merge queue Sep 12, 2023
Merged via the queue into aquasecurity:main with commit ad1dc63 Sep 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding "Signature Verification" Guide to verify signed binaries
4 participants