Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace with sortable packages #4858

Merged
merged 1 commit into from
Jul 24, 2023
Merged

refactor: replace with sortable packages #4858

merged 1 commit into from
Jul 24, 2023

Conversation

knqyf263
Copy link
Collaborator

Description

[]Packages is sorted in many places. This PR replaces Libraries from []Package with Packages so it can be sorted easily.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Jul 23, 2023
@knqyf263 knqyf263 marked this pull request as ready for review July 23, 2023 13:16
DmitriyLewen
DmitriyLewen approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@knqyf263 knqyf263 added this pull request to the merge queue Jul 24, 2023
Merged via the queue into aquasecurity:main with commit 0707569 Jul 24, 2023
@knqyf263 knqyf263 deleted the refactor_packages branch July 24, 2023 07:34
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
@knqyf263 @AnaisUrlichs
refactor: replace with sortable packages (aquasecurity#4858)
ad8606c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knqyf263 @DmitriyLewen