Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nodejs): do not detect lock file in node_modules as an app #4949

Merged
merged 2 commits into from
Aug 6, 2023
Merged

fix(nodejs): do not detect lock file in node_modules as an app #4949

merged 2 commits into from
Aug 6, 2023

Conversation

nikpivkin
Copy link
Contributor

Description

Added a check for skipping lock files in node_modules.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin changed the title fix(npm): do not detect lock file in node_modules as an app fix(nodejs): do not detect lock file in node_modules as an app Aug 4, 2023
@nikpivkin nikpivkin marked this pull request as ready for review August 4, 2023 16:20
@nikpivkin nikpivkin requested a review from knqyf263 as a code owner August 4, 2023 16:20
@knqyf263 knqyf263 added this pull request to the merge queue Aug 6, 2023
Merged via the queue into aquasecurity:main with commit 067a0fc Aug 6, 2023
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
@nikpivkin @knqyf263 @AnaisUrlichs
fix(nodejs): do not detect lock file in node_modules as an app (aquas…
9ec7eda 
…ecurity#4949)

* fix(npm): do not detect lock file in node_modules as an app

* refactor: add x/path.Contains

---------

Co-authored-by: knqyf263 <knqyf263@gmail.com>
@nikpivkin nikpivkin deleted the fix/pkg-lock branch August 15, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(npm): do not detect package-lock.json in node_modules as an app
2 participants
@nikpivkin @knqyf263