Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(report): return severity colors in table format #4969

Merged
merged 3 commits into from
Aug 10, 2023
Merged

fix(report): return severity colors in table format #4969

merged 3 commits into from
Aug 10, 2023

Conversation

DmitriyLewen
Copy link
Contributor

Description

We used xio.NopCloser(os.Stdout) (https://github.com/aquasecurity/trivy/pull/4842/files#diff-80732ba8ca010f5d4649c424c6782a6d91b6a008e1b40b223357296e36af28e1R171).
We need to compare with xio.NopCloser(os.Stdout) for proper terminal detection.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Aug 9, 2023
@DmitriyLewen DmitriyLewen marked this pull request as ready for review August 9, 2023 10:33
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner August 9, 2023 10:33
@knqyf263 knqyf263 added this pull request to the merge queue Aug 10, 2023
Merged via the queue into aquasecurity:main with commit f105279 Aug 10, 2023
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
@DmitriyLewen @AnaisUrlichs
fix(report): return severity colors in table format (aquasecurity#4969)
a544381 
* use xio.NopCloser to compare with os.Stdout

* fmt of import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table output has no severity color
2 participants
@DmitriyLewen @knqyf263