Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Go to 1.20 #5067

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Conversation

DmitriyLewen
Copy link
Contributor

Description

Bump Go to 1.20

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Comment on lines +16 to +18
RUN go install github.com/twitchtv/twirp/protoc-gen-twirp@v8.1.0
RUN go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.27.1
RUN go install github.com/magefile/mage@v1.14.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we can't install different modules with different versions with the same command:

root@c5244beadb12:/go# go install \
    github.com/twitchtv/twirp/protoc-gen-twirp@v8.1.0 \
    google.golang.org/protobuf/cmd/protoc-gen-go@v1.27.1 \
    github.com/magefile/mage@v1.14.0
go: google.golang.org/protobuf/cmd/protoc-gen-go@v1.27.1: all arguments must refer to packages in the same module at the same version (@v8.1.0)
root@c5244beadb12:/go# go install     github.com/twitchtv/twirp/protoc-gen-twirp@v8.1.0     google.golang.org/protobuf/cmd/protoc-gen-go@v1.27.1     github.com/magefile/mage@v1.14.0
go: google.golang.org/protobuf/cmd/protoc-gen-go@v1.27.1: all arguments must refer to packages in the same module at the same version (@v8.1.0)

@DmitriyLewen DmitriyLewen marked this pull request as ready for review August 30, 2023 09:16
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner August 30, 2023 09:16
@knqyf263 knqyf263 added this pull request to the merge queue Aug 30, 2023
Merged via the queue into aquasecurity:main with commit d4ca3cc Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants