Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Bitnami #5078

Merged
merged 2 commits into from
Sep 1, 2023
Merged

docs: add Bitnami #5078

merged 2 commits into from
Sep 1, 2023

Conversation

knqyf263
Copy link
Collaborator

Description

Forgot to commit bitnami.md in #5062

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this Aug 31, 2023
@knqyf263 knqyf263 requested a review from DmitriyLewen August 31, 2023 21:45
Comment on lines +9 to +14

| Scanner | Supported |
| :-----------: | :-------: |
| SBOM | ✓ |
| Vulnerability | ✓ |
| License | ✓ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitnami images can contain OS packages, language files(not described in SPDX files), secrets, etc...
Look like we can separate scanners to image and bitnami package (their SPDX files).

Suggested change
| Scanner | Supported |
| :-----------: | :-------: |
| SBOM ||
| Vulnerability ||
| License ||
| Scanner | Supported for packages | Supported for container |
|:-------------:|:----------------------:|:-----------------------:|
| SBOM |||
| Vulnerability |||
| License |||
| Secret || - |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we can just add info that bitnami are based on debian
how we did it for google distroless - https://github.com/aquasecurity/trivy/blob/main/docs/docs/coverage/os/google-distroless.md#vulnerability

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added fb98884

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 added this pull request to the merge queue Sep 1, 2023
Merged via the queue into aquasecurity:main with commit cdab67e Sep 1, 2023
@knqyf263 knqyf263 deleted the docs/bitnami branch September 1, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants