Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): move to aws-sdk-go-v2 #5381

Merged
merged 4 commits into from
Oct 18, 2023
Merged

chore(deps): move to aws-sdk-go-v2 #5381

merged 4 commits into from
Oct 18, 2023

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Oct 16, 2023 •
edited
Loading

Description

The aws-sdk-go-v2 was announced as general availability
in 2021 and brings few advantages such as not storing
the endpoints list as a global variable, freeing some memory.

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@lebauce lebauce requested a review from knqyf263 as a code owner October 16, 2023 08:59
@lebauce lebauce changed the title Move to aws-sdk-go-v2 chore(deps): move to aws-sdk-go-v2 Oct 16, 2023
knqyf263
knqyf263 reviewed Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks awesome! Left a small question.

pkg/fanal/cache/s3.go Show resolved Hide resolved
knqyf263
knqyf263 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the change and it worked like a charm. Thanks!

@knqyf263 knqyf263 added this pull request to the merge queue Oct 18, 2023
Merged via the queue into aquasecurity:main with commit 9fba79f Oct 18, 2023
12 checks passed
@lebauce
Copy link
Contributor Author

lebauce commented Oct 23, 2023

@knqyf263 Thank you !

@lebauce lebauce mentioned this pull request Oct 30, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lebauce @knqyf263