-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix error when installing PyYAML
for gh pages
#5462
docs: fix error when installing PyYAML
for gh pages
#5462
Conversation
PyYAML
for gh pagesPyYAML
for gh pages
5cb248c
to
9684f83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@knqyf263 I fixed error with docs workflows after update Python to 3.12 (in actions/setup-python@v4
).
But after these changes i thought that perhaps we want just lock Python version on 3.11?
Python will support 3.11 until 2027 year -https://devguide.python.org/versions/
@@ -21,6 +21,7 @@ jobs: | |||
python-version: 3.x | |||
- name: Install dependencies | |||
run: | | |||
python -m pip install --upgrade pip setuptools wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
installing several dependencies required updating setuptools
- https://github.com/aquasecurity/trivy/actions/runs/6663370495/job/18109128951
GitHub also recommends updating setuptools
and wheel
- https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#installing-dependencies
@@ -1,4 +1,4 @@ | |||
FROM squidfunk/mkdocs-material:8.3.9 | |||
FROM squidfunk/mkdocs-material:9.4.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
squidfunk/mkdocs-material:9.4.6
(new version) also returns error for PyYAML 6.0.0
.
Updated it to avoid conflicts with new PyYAML
version other packages after subsequent Python
updates.
We'll face the same problem in 2027. It is good to bump Python. |
Thanks for your great fix, @DmitriyLewen, |
Description
There is problem with old
PyYAML
andPython 3.12
.PyYAML 6.0.1
works correctly inPython 3.12
- yaml/pyyaml#760 (comment)Checklist