Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): fix infinite loop when relativePath field points to pom.xml being scanned #5470

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

DmitriyLewen
Copy link
Contributor

Description

If relativePath (including ../pom.xml case) field points to pom.xml being scanned - we get infinity loop.
More information in aquasecurity/go-dep-parser#267.

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Oct 30, 2023
@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 30, 2023 08:40
@knqyf263 knqyf263 added this pull request to the merge queue Oct 31, 2023
Merged via the queue into aquasecurity:main with commit e2fb3dd Oct 31, 2023
12 checks passed
@DmitriyLewen DmitriyLewen deleted the fix/pom-infinity-loop branch November 20, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(java): infinite loop when parent path + ../pom.xml equals scanned pom.xml
2 participants