feat(misconf): Add support for --cf-params for CFT
#5507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simar <simar@linux.com>
Signed-off-by: Simar <simar@linux.com>
This was referenced Nov 2, 2023
simar7
changed the title
--cf-params for CFT
nikpivkin
reviewed
Nov 2, 2023
nikpivkin
reviewed
Nov 10, 2023
nikpivkin
force-pushed
the
support-cf-params-2
branch
from
71b4acb to
cb21634
Compare
|
@knqyf263 could you take a look at reviewing it? |
knqyf263
reviewed
Nov 15, 2023
pkg/flag/misconf_flags.go
Outdated
| @@ -55,6 +55,12 @@ var ( | |||
| Default: []string{}, | |||
| Usage: "specify paths to override the Terraform tfvars files", | |||
| } | |||
| CfParamsFlag = Flag{ | |||
| Name: "cf-params", | |||
| ConfigName: "misconfiguration.cloudformation.vars", | |||
There was a problem hiding this comment.
nit: cloudformation.vars is a bit different from the CLI flag. Is it intended? cloudformation.params seems more aligned.
knqyf263
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
LGTM, but I'd defer to @nikpivkin. He recently spent more time on misconfiguration scanning than me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the support to pass in Cloudformation template files via
--cf-paramsflag, similar to-tf-varsRelated issues
Required stacked PRs for release (this PR will be merged into the following PR)
Checklist