Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(misconf): don't remove Highlighted in json format #5531

Merged
merged 1 commit into from
Nov 8, 2023
Merged

refactor(misconf): don't remove Highlighted in json format #5531

merged 1 commit into from
Nov 8, 2023

Conversation

DmitriyLewen
Copy link
Contributor

Description

We need to save Highlighted field in json format to retain option to display colored text in convert mode.
See more in #5514.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Nov 7, 2023
@DmitriyLewen DmitriyLewen marked this pull request as ready for review November 7, 2023 07:32
@knqyf263 knqyf263 added this pull request to the merge queue Nov 7, 2023
Merged via the queue into aquasecurity:main with commit a1b4744 Nov 8, 2023
12 checks passed
@DmitriyLewen DmitriyLewen deleted the refactor/do-not-remove-highlighed-fields-for-json branch November 20, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Converting JSON report to TABLE report missing code blocks when output to console
2 participants
@DmitriyLewen @knqyf263